ostree-repo-pull: Fix a leak of the summary data if loading from cache
authorPhilip Withnall <pwithnall@endlessos.org>
Tue, 9 Mar 2021 11:47:23 +0000 (11:47 +0000)
committerPhilip Withnall <pwithnall@endlessos.org>
Tue, 9 Mar 2021 11:47:23 +0000 (11:47 +0000)
commit60881b75ecb4166c89bb9b3392b5126557aaa6f0
tree1014d95b91b90ee116540f2aefb45159843bcdc6
parentf9a38436fa10c10f6904c138d28c96efd212bfb0
ostree-repo-pull: Fix a leak of the summary data if loading from cache

If the `summary_sig_not_modified` branch is taken above, both
`signatures` and `summary` are loaded from the cache. This makes the
`_ostree_repo_load_cache_summary_if_same_sig()` call below redundant (it
checks `signatures` matches the file it was just loaded from, and then
loads `summary` again) — but that call also currently overwrites
`summary` without clearing the old value.

Fix this by only making that call if `signatures` was retrieved, but the
server said the local `summary` cache was invalid.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
src/libostree/ostree-repo-pull.c